[hle/sockets] fix crash when socket() isn't initialized but send()/recv() are called (#3729)

the correct behaviour would be for the hle service NOT to crash

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3729
Reviewed-by: Maufeat <sahyno1996@gmail.com>
Reviewed-by: MaranBr <maranbr@eden-emu.dev>

src/core/hle/service/sockets/bsd.cpp

@@ -11,6 +11,7 @@
 
 #include <fmt/ranges.h>
 
+#include "common/logging.h"
 #include "common/socket_types.h"
 #include "core/core.h"
 #include "core/hle/kernel/k_thread.h"
@@ -630,6 +631,11 @@ Errno BSD::BindImpl(s32 fd, std::span<const u8> addr) {
         return Errno::BADF;
     }
     ASSERT(addr.size() >= 16);
+    if (!file_descriptors[fd]->socket) {
+        LOG_WARNING(Service, "Uninitialized socket");
+        return Errno::BADF;
+    }
+
     auto addr_in = GetValue<SockAddrIn>(addr);
 
     return Translate(file_descriptors[fd]->socket->Bind(Translate(addr_in)));
@@ -641,6 +647,11 @@ Errno BSD::ConnectImpl(s32 fd, std::span<const u8> addr) {
     }
 
     ASSERT(addr.size() >= 16);
+    if (!file_descriptors[fd]->socket) {
+        LOG_WARNING(Service, "Uninitialized socket");
+        return Errno::BADF;
+    }
+
     auto addr_in = GetValue<SockAddrIn>(addr);
 
     const Errno result = Translate(file_descriptors[fd]->socket->Connect(Translate(addr_in)));
@@ -658,6 +669,11 @@ Errno BSD::GetPeerNameImpl(s32 fd, std::vector<u8>& write_buffer) {
         return Errno::BADF;
     }
 
+    if (!file_descriptors[fd]->socket) {
+        LOG_WARNING(Service, "Uninitialized socket");
+        return Errno::BADF;
+    }
+
     const auto [addr_in, bsd_errno] = file_descriptors[fd]->socket->GetPeerName();
     if (bsd_errno != Network::Errno::SUCCESS) {
         return Translate(bsd_errno);
@@ -675,6 +691,11 @@ Errno BSD::GetSockNameImpl(s32 fd, std::vector<u8>& write_buffer) {
         return Errno::BADF;
     }
 
+    if (!file_descriptors[fd]->socket) {
+        LOG_WARNING(Service, "Uninitialized socket");
+        return Errno::BADF;
+    }
+
     const auto [addr_in, bsd_errno] = file_descriptors[fd]->socket->GetSockName();
     if (bsd_errno != Network::Errno::SUCCESS) {
         return Translate(bsd_errno);
@@ -691,6 +712,10 @@ Errno BSD::ListenImpl(s32 fd, s32 backlog) {
     if (!IsFileDescriptorValid(fd)) {
         return Errno::BADF;
     }
+    if (!file_descriptors[fd]->socket) {
+        LOG_WARNING(Service, "Uninitialized socket");
+        return Errno::BADF;
+    }
     return Translate(file_descriptors[fd]->socket->Listen(backlog));
 }
 
@@ -698,6 +723,10 @@ std::pair<s32, Errno> BSD::FcntlImpl(s32 fd, FcntlCmd cmd, s32 arg) {
     if (!IsFileDescriptorValid(fd)) {
         return {-1, Errno::BADF};
     }
+    if (!file_descriptors[fd]->socket) {
+        LOG_WARNING(Service, "Uninitialized socket");
+        return {-1, Errno::BADF};
+    }
 
     FileDescriptor& descriptor = *file_descriptors[fd];
 
@@ -724,6 +753,10 @@ Errno BSD::GetSockOptImpl(s32 fd, u32 level, OptName optname, std::vector<u8>& o
     if (!IsFileDescriptorValid(fd)) {
         return Errno::BADF;
     }
+    if (!file_descriptors[fd]->socket) {
+        LOG_WARNING(Service, "Uninitialized socket");
+        return Errno::BADF;
+    }
 
     if (level != static_cast<u32>(SocketLevel::SOCKET)) {
         UNIMPLEMENTED_MSG("Unknown getsockopt level");
@@ -755,6 +788,10 @@ Errno BSD::SetSockOptImpl(s32 fd, u32 level, OptName optname, std::span<const u8
     if (!IsFileDescriptorValid(fd)) {
         return Errno::BADF;
     }
+    if (!file_descriptors[fd]->socket) {
+        LOG_WARNING(Service, "Uninitialized socket");
+        return Errno::BADF;
+    }
 
     if (level != static_cast<u32>(SocketLevel::SOCKET)) {
         LOG_WARNING(Service, "(STUBBED) setsockopt with level={}, optname={}", level, optname);
@@ -805,6 +842,10 @@ Errno BSD::ShutdownImpl(s32 fd, s32 how) {
     if (!IsFileDescriptorValid(fd)) {
         return Errno::BADF;
     }
+    if (!file_descriptors[fd]->socket) {
+        LOG_WARNING(Service, "Uninitialized socket");
+        return Errno::BADF;
+    }
     const Network::ShutdownHow host_how = Translate(static_cast<ShutdownHow>(how));
     return Translate(file_descriptors[fd]->socket->Shutdown(host_how));
 }
@@ -887,6 +928,10 @@ std::pair<s32, Errno> BSD::SendImpl(s32 fd, u32 flags, std::span<const u8> messa
     if (!IsFileDescriptorValid(fd)) {
         return {-1, Errno::BADF};
     }
+    if (!file_descriptors[fd]->socket) {
+        LOG_WARNING(Service, "Uninitialized socket");
+        return {-1, Errno::BADF};
+    }
     return Translate(file_descriptors[fd]->socket->Send(message, flags));
 }
 
@@ -895,6 +940,10 @@ std::pair<s32, Errno> BSD::SendToImpl(s32 fd, u32 flags, std::span<const u8> mes
     if (!IsFileDescriptorValid(fd)) {
         return {-1, Errno::BADF};
     }
+    if (!file_descriptors[fd]->socket) {
+        LOG_WARNING(Service, "Uninitialized socket");
+        return {-1, Errno::BADF};
+    }
 
     Network::SockAddrIn addr_in;
     Network::SockAddrIn* p_addr_in = nullptr;
@@ -912,6 +961,10 @@ Errno BSD::CloseImpl(s32 fd) {
     if (!IsFileDescriptorValid(fd)) {
         return Errno::BADF;
     }
+    if (!file_descriptors[fd]->socket) {
+        LOG_WARNING(Service, "Uninitialized socket");
+        return Errno::BADF;
+    }
 
     const Errno bsd_errno = Translate(file_descriptors[fd]->socket->Close());
     if (bsd_errno != Errno::SUCCESS) {
@@ -947,6 +1000,10 @@ std::optional<std::shared_ptr<Network::SocketBase>> BSD::GetSocket(s32 fd) {
     if (!IsFileDescriptorValid(fd)) {
         return std::nullopt;
     }
+    if (!file_descriptors[fd]->socket) {
+        LOG_WARNING(Service, "Uninitialized socket");
+        return std::nullopt;
+    }
     return file_descriptors[fd]->socket;
 }