From 3d0730a7d856404ed268f0eb1813cae6c65af59f Mon Sep 17 00:00:00 2001 From: chrelliott978 Date: Wed, 7 Jan 2026 01:59:59 +0100 Subject: [PATCH] Fix MoltenVK subgroup scope error in SPIR-V emission Removed incorrect __APPLE__ preprocessor check that was forcing Workgroup scope for subgroup operations. MoltenVK requires Subgroup scope, not Workgroup scope. This fixes the error: "SPIR-V to MSL conversion error: Only subgroup scope is supported." --- src/shader_recompiler/backend/spirv/emit_spirv_warp.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/shader_recompiler/backend/spirv/emit_spirv_warp.cpp b/src/shader_recompiler/backend/spirv/emit_spirv_warp.cpp index 8771801226..77ff8c5731 100644 --- a/src/shader_recompiler/backend/spirv/emit_spirv_warp.cpp +++ b/src/shader_recompiler/backend/spirv/emit_spirv_warp.cpp @@ -7,12 +7,7 @@ namespace Shader::Backend::SPIRV { namespace { Id SubgroupScope(EmitContext& ctx) { -#ifdef __APPLE__ - // MoltenVK doesn't support Subgroup scope for compute shaders - return ctx.Const(static_cast(spv::Scope::Workgroup)); -#else return ctx.Const(static_cast(spv::Scope::Subgroup)); -#endif } Id GetThreadId(EmitContext& ctx) {