Browse Source

gc_poller: Get rid of undefined behavior in Create()

Ensures that the function always has returns in all control paths.
nce_cpp
Lioncash 6 years ago
parent
commit
340875a12f
  1. 4
      src/input_common/gcadapter/gc_poller.cpp

4
src/input_common/gcadapter/gc_poller.cpp

@ -6,6 +6,7 @@
#include <list> #include <list>
#include <mutex> #include <mutex>
#include <utility> #include <utility>
#include "common/assert.h"
#include "common/threadsafe_queue.h" #include "common/threadsafe_queue.h"
#include "input_common/gcadapter/gc_adapter.h" #include "input_common/gcadapter/gc_adapter.h"
#include "input_common/gcadapter/gc_poller.h" #include "input_common/gcadapter/gc_poller.h"
@ -94,6 +95,9 @@ std::unique_ptr<Input::ButtonDevice> GCButtonFactory::Create(const Common::Param
return std::make_unique<GCAxisButton>(port, axis, threshold, trigger_if_greater, return std::make_unique<GCAxisButton>(port, axis, threshold, trigger_if_greater,
adapter.get()); adapter.get());
} }
UNREACHABLE();
return nullptr;
} }
Common::ParamPackage GCButtonFactory::GetNextInput() { Common::ParamPackage GCButtonFactory::GetNextInput() {

Loading…
Cancel
Save