Browse Source
Merge pull request #2198 from lioncash/todo
{kernel/thread, video_core/surface}: Remove obsolete TODOs
pull/15/merge
bunnei
7 years ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with
0 additions and
4 deletions
-
src/core/hle/kernel/thread.cpp
-
src/video_core/surface.cpp
|
|
|
@ -184,8 +184,6 @@ ResultVal<SharedPtr<Thread>> Thread::Create(KernelCore& kernel, std::string name |
|
|
|
return ERR_INVALID_PROCESSOR_ID; |
|
|
|
} |
|
|
|
|
|
|
|
// TODO(yuriks): Other checks, returning 0xD9001BEA
|
|
|
|
|
|
|
|
if (!Memory::IsValidVirtualAddress(owner_process, entry_point)) { |
|
|
|
LOG_ERROR(Kernel_SVC, "(name={}): invalid entry {:016X}", name, entry_point); |
|
|
|
// TODO (bunnei): Find the correct error code to use here
|
|
|
|
|
|
|
|
@ -89,8 +89,6 @@ PixelFormat PixelFormatFromDepthFormat(Tegra::DepthFormat format) { |
|
|
|
|
|
|
|
PixelFormat PixelFormatFromRenderTargetFormat(Tegra::RenderTargetFormat format) { |
|
|
|
switch (format) { |
|
|
|
// TODO (Hexagon12): Converting SRGBA to RGBA is a hack and doesn't completely correct the
|
|
|
|
// gamma.
|
|
|
|
case Tegra::RenderTargetFormat::RGBA8_SRGB: |
|
|
|
return PixelFormat::RGBA8_SRGB; |
|
|
|
case Tegra::RenderTargetFormat::RGBA8_UNORM: |
|
|
|
|